Add detection QE spread for outlier estimation #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Jul 17, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
=======================================
Coverage 73.91% 73.92%
=======================================
Files 125 125
Lines 12548 12550 +2
=======================================
+ Hits 9275 9277 +2
Misses 3273 3273
☔ View full report in Codecov by Sentry. |
maxnoe
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the detection QE dispersion over the camera (~7%) to estimate the cuts for selecting pixels outliers on the base of the calculated number of pe by the F factor method. In a first step we neglected the ~6-7% dispersion, which is ok for the standard FF intensity but not for filters delivering to very high FF intensities (> 1000 pe/pixel). This ended up with many pixels wrongly set as outliers for the last high intensity points of the filter scan.